Skip to content
This repository was archived by the owner on Feb 7, 2025. It is now read-only.

fix error #22

Closed
wants to merge 1 commit into from
Closed

fix error #22

wants to merge 1 commit into from

Conversation

BilikoX
Copy link
Contributor

@BilikoX BilikoX commented Apr 26, 2023

Preserve Real-Ip when not accessed through cloudflare

@mrinc
Copy link
Member

mrinc commented May 12, 2023

@Amadeus331 See build status, linting failed for complexity.

It would break normal behavour, so let's rather make it an optional config option and split into seperate statement.

@mrinc
Copy link
Member

mrinc commented May 12, 2023

*We also must add tests for this change

@BilikoX
Copy link
Contributor Author

BilikoX commented May 15, 2023

@Amadeus331 See build status, linting failed for complexity.

It would break normal behavour, so let's rather make it an optional config option and split into seperate statement.

It's my fault. I shouldn't have added the local IP to trustIP. Now close PR

@BilikoX BilikoX closed this May 15, 2023
@BilikoX
Copy link
Contributor Author

BilikoX commented May 15, 2023

@Amadeus331 See build status, linting failed for complexity.
It would break normal behavour, so let's rather make it an optional config option and split into seperate statement.

It's my fault. I shouldn't have added the local IP to trustIP. Now close PR

When the request comes from a trusted proxy other than of cloudflare, there is still a problem

@BilikoX
Copy link
Contributor Author

BilikoX commented May 15, 2023

@Amadeus331 See build status, linting failed for complexity.
It would break normal behavour, so let's rather make it an optional config option and split into seperate statement.

It's my fault. I shouldn't have added the local IP to trustIP. Now close PR

When the request comes from a trusted proxy other than of cloudflare, there is still a problem

I resubmitted the pull request, and it passed the test this time.
#24 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants